Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add DaemonSet e2e test #143

Merged
merged 3 commits into from
May 22, 2023
Merged

Conversation

Jackie1457
Copy link
Contributor

Ⅰ. Description

Add DaemonSet e2e tests including 3 cases:

  1. Normal rollout update:
    "DaemonSet V1->V2: 1,100% Succeeded"

  2. v1 -> v2(interrupt) -> v3
    "V1->V2: Percentage, 1, 2 and continuous release v3"

  3. delete rollout during the process
    "V1->V2: 1,100%, but delete rollout crd"

Ⅱ. Test Process

  1. Set up basic environment according to this md:
    https://github.com/openkruise/rollouts/blob/master/docs/contributing/debug.md

  2. run kubectl apply -f rollout_canary_daemonset_base.yaml, and rollout_canary_daemonset_base.yaml is under the path:
    test/e2e/test_data/rollout/rollout_canary_daemonset_base.yaml

  3. run kubectl apply -f rollout_canary_daemonset_interrupt.yaml, and rollout_canary_daemonset_interrupt.yaml is under the path:
    test/e2e/test_data/rollout/rollout_canary_daemonset_interrupt.yaml

  4. run ginkgo -timeout 60m -v --focus="DaemonSet canary rollout" test/e2e under rollouts package.

Ⅲ. Test Result

All three cases passed
1)
Screen Shot 2023-04-27 at 17 06 32
2)
Screen Shot 2023-04-27 at 17 07 32
3)
Screen Shot 2023-04-27 at 17 16 35

Signed-off-by: janice1457 <[email protected]>
@kruise-bot kruise-bot requested review from furykerry and veophi May 8, 2023 23:51
@codecov-commenter
Copy link

codecov-commenter commented May 9, 2023

Codecov Report

Merging #143 (661ee39) into master (5626a7f) will not change coverage.
The diff coverage is n/a.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@           Coverage Diff           @@
##           master     #143   +/-   ##
=======================================
  Coverage   44.61%   44.61%           
=======================================
  Files          48       48           
  Lines        5045     5045           
=======================================
  Hits         2251     2251           
  Misses       2422     2422           
  Partials      372      372           
Flag Coverage Δ
unittests 44.61% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

test/e2e/rollout_test.go Outdated Show resolved Hide resolved
test/e2e/rollout_test.go Outdated Show resolved Hide resolved
.github/workflows/e2e-daemonset-1.19.yaml Show resolved Hide resolved
Copy link
Member

@furykerry furykerry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@veophi
Copy link
Member

veophi commented May 22, 2023

/lgtm

@furykerry
Copy link
Member

/approve

@kruise-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: furykerry

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kruise-bot kruise-bot merged commit 7f06e27 into openkruise:master May 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants